[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

Mon Nov 28 13:09:25 PST 2022

mtrofin added a comment.

In D138836#3954851 <https://reviews.llvm.org/D138836#3954851>, @lebedev.ri wrote:

> In D138836#3954850 <https://reviews.llvm.org/D138836#3954850>, @mtrofin wrote:
>
>> In D138836#3954782 <https://reviews.llvm.org/D138836#3954782>, @lebedev.ri wrote:
>>
>>> Thanks!
>>> There's also the one for MCA, but this situation basically never happens for those tests.
>>
>> Yup, checked that and the mir one. The latter seems to be implementing its own "add_checks", so would leave it as-is (plus, I'm guessing, by their nature, mir tests wouldn't get into this type of scenario anyway, IIUC).
>
> mca!=mir

Right - they are different, there's a update_mir_test_checks and also an update_mca_test_checks; basically agreeing that, indeed, after patching _cc and _analysis (and update_test_checks), the remaining don't need patching.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138836/new/

https://reviews.llvm.org/D138836