[PATCH] D138780: [include-cleaner] Merge 2 parseIWYUPragma impls in libToolingInclusions

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 28 05:45:24 PST 2022


sammccall added a comment.

In D138780#3953229 <https://reviews.llvm.org/D138780#3953229>, @ABataev wrote:

> Looks like it breaks the build:
>
>   llvm-project/clang-tools-extra/clangd/index/CanonicalIncludes.cpp: In member function ‘virtual bool clang::clangd::collectIWYUHeaderMaps(clang::clangd::CanonicalIncludes*)::PragmaCommentHandler::HandleComment(clang::Preprocessor&, clang::SourceRange)’:
>   llvm-project/clang-tools-extra/clangd/index/CanonicalIncludes.cpp:713:21: error: ‘parseIWYUPragma’ was not declared in this scope
>          auto Pragma = parseIWYUPragma(
>                        ^~~~~~~~~~~~~~~

Sorry, this is fixed in 551c7e81891abcf49aff625187f348ff119c4618 <https://reviews.llvm.org/rG551c7e81891abcf49aff625187f348ff119c4618> (I was running tests in the wrong terminal...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138780/new/

https://reviews.llvm.org/D138780



More information about the cfe-commits mailing list