[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

In D137205#3952864 <https://reviews.llvm.org/D137205#3952864>, @carlosgalvezp wrote:

>> by design clang-format only performs white-space changes
>
> clang-format does support east/west const enforcement with the `QualifierAlignment` option. From experience, I strongly encourage repo owners to enable it repo-wide to avoid these kinds of discussions.

FWIW, one reason this isn't enabled is that it's relatively recent and also not completely safe <https://reviews.llvm.org/D69764#2056105> in principle.
It's not as simple as "if LLVM cares about const-alignment, this flag should be on".

(And I don't think @carlosgalvezp was saying it was that simple! I'm just saying we can't rehash the discussion here because it's too big - maybe we should elsewhere).

> Until then, I believe developers should keep consistency with the existing style in the codebase, regardless of personal views. This goes in line with the LLVM Coding Standards:

+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137205/new/

https://reviews.llvm.org/D137205