[PATCH] D138709: Reland "[Lex] Fix suggested spelling of /usr/bin/../include/foo"

[Sam McCall via Phabricator via cfe-commits]

sammccall marked an inline comment as done.
sammccall added inline comments.


================
Comment at: clang/unittests/Lex/HeaderSearchTest.cpp:155
+  addSearchDir("/x/../y/");
+  EXPECT_EQ(Search.suggestPathToFileForDiagnostics("/x/../y/z",
+                                                   /*WorkingDir=*/"",
----------------
kadircet wrote:
> can you also add a new test that looks like:
> ```
> addSearchDir("x/");
> EXPECT(suggestForDiag("x\y\z.h"), "y/z.h");
> ```
> 
> as in theory that's the new behaviour we're adding.
That looks a lot like `TEST_F(HeaderSearchTest, BackSlash)` to me (relative vs absolute, but not relevant at least to this change)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138709/new/

https://reviews.llvm.org/D138709