[PATCH] D138749: [clang] Compare constraints before diagnosing mismatched ref qualifiers (GH58962)

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 27 05:01:59 PST 2022


cor3ntin added inline comments.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:1324
+    if ((NewRC != nullptr) != (OldRC != nullptr))
+      // RC are most certainly different - these are overloads.
+      return true;
----------------
I know it's preexisting but, I'm not sure that comment adds anything.
If we want to keep it, "requires clauses are different, - these are overloads."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138749/new/

https://reviews.llvm.org/D138749



More information about the cfe-commits mailing list