[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

[Ben Boeckel via Phabricator via cfe-commits]

ben.boeckel added inline comments.


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:197
+llvm::cl::opt<std::string> P1689TargetedCommand(
+    "p1689-targeted-command", llvm::cl::Optional,
+    llvm::cl::desc("Only supported for P1689, the targeted command of which "
----------------
ChuanqiXu wrote:
> ben.boeckel wrote:
> > Can this be something like `--` so that I don't have to figure out how to quote the thing (for the shell and whatever parsing Clang does internally)?
> Yeah, it can. Both `-` and `--` are accepted. I've updated the test to disambiguate.
I don't mean the flag using `--` as a prefix. I don't care about that. What I *do* care about is having to quote everything I'd give to `clang` here. I'd vastly prefer something like:

```
clang-scan-deps -p1689-targeted-file-name=… -p1689-use-command -- -flags --for ---clang --go --here
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137534/new/

https://reviews.llvm.org/D137534