[PATCH] D138489: [tsan] Add tsan support for loongarch64
Lu Weining via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 25 05:02:01 PST 2022
SixWeining added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1543
+ "r"(__fn), "r"(__arg), "r"(nr_clone), "i"(__NR_exit)
+ : "memory");
+ return res;
----------------
xry111 wrote:
> xry111 wrote:
> > SixWeining wrote:
> > > tangyouling wrote:
> > > > SixWeining wrote:
> > > > > Shall we list $t0-$t8 here? Ref D137396.
> > > > > Shall we list $t0-$t8 here? Ref D137396.
> > > >
> > > > I will add the missing $t0-$t8.
> > > As this inline asm is almost at the end of the function, it's sure `$t*` would not be used any more. So I think we could not add them to the clobber list. Just keep current approach.
> > It's hard to tell: the compiler may decide to inline this function of perform some inter-procedural analysis. So IMO we should add t0-t8 here.
> > It's hard to tell: the compiler may decide to inline this function of perform some inter-procedural analysis. So IMO we should add t0-t8 here.
>
> "or perform", not "of perform".
Make sense. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138489/new/
https://reviews.llvm.org/D138489
More information about the cfe-commits
mailing list