[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 24 06:17:25 PST 2022


svenvh added inline comments.


================
Comment at: clang/include/clang/Basic/OpenCLExtensions.def:123
+OPENCL_OPTIONALCOREFEATURE(__opencl_c_work_group_collective_functions, false, 300, OCL_C_30)
+OPENCL_OPTIONALCOREFEATURE(__opencl_c_int64, false, 300, OCL_C_30)
 
----------------
I am wondering why those features weren't added together with the other OpenCL 3.0 features; there wasn't any discussion around that in D95776.  Perhaps it's because these don't affect the compiler behaviour directly? (but then neither does e.g. `__opencl_c_atomic_order_acq_rel`)  Wondering if @Anastasia has any insights here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137652/new/

https://reviews.llvm.org/D137652



More information about the cfe-commits mailing list