[PATCH] D138559: Record macro references in #ifdef clause.
Viktoriia Bakalova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 24 02:31:04 PST 2022
VitaNuo added inline comments.
================
Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:248
+ SourceManager &SM = AST.sourceManager();
+ ASSERT_THAT(Recorded.MacroReferences, Not(IsEmpty()));
+
----------------
hokein wrote:
> nit: this can be removed, as the EXPECT_THAT on line 258 covers this.
Sorry, not sure what this comment refers to. Can it be that the line numbering changed due to my newer patch, and this comment does not show up in the correct place anymore?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138559/new/
https://reviews.llvm.org/D138559
More information about the cfe-commits
mailing list