[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/3)

[Ben Boeckel via Phabricator via cfe-commits]

ben.boeckel added inline comments.


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:192
+    "p1689-targeted-directory", llvm::cl::Optional,
+    llvm::cl::desc("Only supported for P1689, the targeted directory of which "
+                   "the dependencies are to be computed."),
----------------
I'm not sure what this means. Is it the compiler's working directory when compiling?


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:197
+llvm::cl::opt<std::string> P1689TargetedCommand(
+    "p1689-targeted-command", llvm::cl::Optional,
+    llvm::cl::desc("Only supported for P1689, the targeted command of which "
----------------
Can this be something like `--` so that I don't have to figure out how to quote the thing (for the shell and whatever parsing Clang does internally)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137534/new/

https://reviews.llvm.org/D137534