[PATCH] D138319: [analyzer] Prepare structures for integral cast feature introducing

[Balázs Benics via Phabricator via cfe-commits]

steakhal added a comment.

I spent some time on this patch. But I'm left thinking about why we need the extra indirection?
Couldn't we just use a `std::pair<sym,width>` pair as a key instead?
You mention //effective// bitwidths in your summary, but the code does not mention this concept.
Maybe you could elaborate on what //effective// bitwidth means in this context and how this changes the eqclass lookups.
In addition to this, I'd be curious about an informal proof of the correctness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138319/new/

https://reviews.llvm.org/D138319