[PATCH] D138377: add clang_Type_getFullyQualifiedName
Anders Langlands via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 22 23:53:33 PST 2022
anderslanglands added inline comments.
================
Comment at: clang/tools/c-index-test/c-index-test.c:1787
PrintCursor(cursor, NULL);
+ VisitorData *Data = (VisitorData *)d;
PrintSingleTypeSize(T, " [type=%s] [typekind=%s]", " [sizeof=%lld]",
----------------
anderslanglands wrote:
> aaron.ballman wrote:
> > I'm not super familiar with c-index-test -- how certain are you that the client data will 1) be non-null, and 2) actually be a `VisitorData` pointer?
> This was just copy-pasted from another function. I'm as certain as I can be given that all the tests pass :\
>From a quick scan, VisitorData is the only CXClientData struct used in the visitor callbacks, so I think we're safe.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138377/new/
https://reviews.llvm.org/D138377
More information about the cfe-commits
mailing list