[PATCH] D138473: clang/HIP: Inline frexp/frexpf implementations

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D138473#3944586 <https://reviews.llvm.org/D138473#3944586>, @yaxunl wrote:

> Are you sure these functions are equivalent? we do not have a comprehensive test for these functions regarding accuracy.

These are ultimately simple bit extracts. The library implementation just calls these intrinsics. The only difference from the current library code and here is a check to handle infinities and nans, which the ISA manual suggests is unnecessary. I have another patch to eliminate the check there


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138473/new/

https://reviews.llvm.org/D138473