[PATCH] D138507: HIP: Directly use sqrt builtins instead of calling ocml (f32 case)

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 09:03:19 PST 2022


arsenm added a comment.

In D138507#3944358 <https://reviews.llvm.org/D138507#3944358>, @b-sumner wrote:

> __builtin_sqrtf does not produce a correctly rounded result.  I don't recommend this change.

It's supposed to. I'm working towards correctly handling these in the backend


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138507/new/

https://reviews.llvm.org/D138507



More information about the cfe-commits mailing list