[PATCH] D138507: HIP: Directly use sqrt builtins instead of calling ocml (f32 case)

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 08:49:11 PST 2022


arsenm created this revision.
arsenm added reviewers: b-sumner, yaxunl, JonChesterfield.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.

The wrappers aren't buying anything and just add complexity.
We do not propagate fast math flags into the linked library functions,
but they'll naturally be applied if the intrinsic is directly emitted.

      

We also don't need to treat the native case differently, since we just
directly select the generic intrinsic anyway.

      

f64 case requires a backend change, so defer that for now.


https://reviews.llvm.org/D138507

Files:
  clang/lib/Headers/__clang_hip_math.h
  clang/test/Headers/__clang_hip_math.hip

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138507.477216.patch
Type: text/x-patch
Size: 140903 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221122/f1de5247/attachment-0001.bin>


More information about the cfe-commits mailing list