[PATCH] D138289: [clang][Parse] Remove constant expression from if condition
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 22 05:01:02 PST 2022
aaron.ballman added a comment.
In D138289#3943090 <https://reviews.llvm.org/D138289#3943090>, @tbaeder wrote:
> Yeah, just removing the `MaybeTypeCast` worked, but switching to `isTypeCast` doens't.
I think for now we can remove the `MaybeTypeCast` entirely. We only set `isTypeCast` once we *know* we're dealing with a type cast, and this is about typo correction where we probably don't know what we're dealing with. Given that it's a no-op change to do that, removing it leaves us in no worse shape than we were before.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138289/new/
https://reviews.llvm.org/D138289
More information about the cfe-commits
mailing list