[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 22 00:41:34 PST 2022


owenpan added inline comments.


================
Comment at: clang/unittests/Format/FormatTestComments.cpp:736
+      "//* 0.2)",
+      "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)");
 }
----------------
owenpan wrote:
> HazardyKnusperkeks wrote:
> > owenpan wrote:
> > > ```
> > > error: reference to type 'const clang::format::FormatStyle' could not bind to an lvalue of type 'const char[61]'
> > >       "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)");
> > >       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > ```
> > Just needs the verifyFormat from D138263.
> I see. Do you want to stack this patch onto D138263 (which I might not be able to get to for a while) or copy the needed code from there to here?
Nvm. It's stacked now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138402/new/

https://reviews.llvm.org/D138402



More information about the cfe-commits mailing list