[PATCH] D138464: Return None instead of Optional<T>() (NFC)

Kazu Hirata via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 18:54:12 PST 2022


kazu added a comment.

Thanks for the review!

In D138464#3942626 <https://reviews.llvm.org/D138464#3942626>, @MaskRay wrote:

> We have `return llvm::None;` and `return None;`. Shall we always prefer `llvm::None`?

Either one is OK (to me).  I can deprecate `None` in my personal tree, and get a warning for both `llvm::None` and `None`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138464/new/

https://reviews.llvm.org/D138464



More information about the cfe-commits mailing list