[PATCH] D138458: [Clang][Driver] Add KCFI to SupportsCoverage

Sami Tolvanen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 15:05:48 PST 2022


samitolvanen added inline comments.


================
Comment at: clang/test/CodeGen/sanitize-coverage.c:94
+  // CHECK-NOT: call void @__sanitizer_cov_trace_const_cmp
+  // KCFI-NOT: call void %{{.}}() [ "kcfi"(i32 {{.*}}) ]
+  f();
----------------
MaskRay wrote:
> `%c()`
> 
> `{{.}}` matches one byte. Just write the byte.
> `%c()`
> 
> `{{.}}` matches one byte. Just write the byte.

I do want to match just one byte, but the actual byte changes depending on how many statements there are in the function, so matching any byte seems less fragile. `%c` would match literally just `%c`. Am I missing some neat FileCheck trick here that would save me a ton of typing in future...?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138458/new/

https://reviews.llvm.org/D138458



More information about the cfe-commits mailing list