[PATCH] D136594: [clangd] Add support for semantic token type "operator"

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 14:06:02 PST 2022


nridge added a comment.

In D136594#3940482 <https://reviews.llvm.org/D136594#3940482>, @sammccall wrote:

> I think since LSP specifies an `operator` SemanticTokenType, we should use it unless there's a *really* strong reason not to.

My bad, I completely overlooked that LSP has a standard token type for this! (I think maybe because I assumed D119077 <https://reviews.llvm.org/D119077> would have used it had it existed.) In light of that, please disregard my comment about making operator a modifier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136594/new/

https://reviews.llvm.org/D136594



More information about the cfe-commits mailing list