[PATCH] D138426: Fix #58958 on github

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 13:29:58 PST 2022


xazax.hun added inline comments.


================
Comment at: clang/lib/Sema/SemaFixItUtils.cpp:136-137
+    // Do no take address of const pointer to get void*
+    const PointerType *FromPtrTy = dyn_cast<PointerType>(FromQTy);
+    const PointerType *ToPtrTy = dyn_cast<PointerType>(ToQTy);
+    if (FromPtrTy && FromPtrTy->getPointeeType().isConstQualified() &&
----------------
Nit: we usually try to avoid repeating types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138426/new/

https://reviews.llvm.org/D138426



More information about the cfe-commits mailing list