[PATCH] D138425: [clangd] Parameter hints for template specialization

Tom Praschan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 13:19:50 PST 2022


tom-anders added a comment.

In D138425#3941206 <https://reviews.llvm.org/D138425#3941206>, @sammccall wrote:

> In D138425#3941183 <https://reviews.llvm.org/D138425#3941183>, @v1nh1shungry wrote:
>
>> Yes, there is a common situation where people use a meaningless template parameter name, but I think the same for functions.
>
> I don't think it's the same: my wild guess would be 30% of function params have useless names, and 90% of template params do.
> If this were accurate, it seems function param hints are usually (potentially) useful, while template params are almost always useless.

I agree that is usually useless and too much noise, especially for container like types. But, it could maybe be useful for template parameters that have a default value? For example, I'll never need an inlay hint for something like `std::map<K, V>, but when passing a custom comparator and allocator as the 3rd and 4th template type, inlay hints might actually be helpful there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138425/new/

https://reviews.llvm.org/D138425



More information about the cfe-commits mailing list