[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 11:59:01 PST 2022


HazardyKnusperkeks added a comment.

In D138402#3940981 <https://reviews.llvm.org/D138402#3940981>, @rymiel wrote:

> The behaviour of tabs still doesn't match that of spaces, but at least this makes it idempotent.

I did initially looked into that, but then asked do we want to treat tabs equally to spaces?
It would add a lot of logic, and the question how to map `SpacesInLineCommentPrefix` to tabs?

> This also fixes https://github.com/llvm/llvm-project/issues/51808, I'm closing it as duplicate in favor of the issue fixed by this patch.

Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138402/new/

https://reviews.llvm.org/D138402



More information about the cfe-commits mailing list