[PATCH] D137794: [clangd] Enable configuring include insertions

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 21 04:37:50 PST 2022


sammccall added a comment.

The replacement rules design is just too complicated I'm afraid.
It's unclear that it solves a widespread problem, and even when there is one and the solution applies, the result is still difficult to use.

Angles vs quotes is something we've had multiple reports on, though, and may be narrow enough to find a simple solution.

- maybe something config-based like `Style: { IncludeAngled: 'match/a/suffix/.*' }`
- or something based on seeing how the header is included and storing this in the index. This is nice as it avoids config, but seems complicated in other ways (unpredictable, relies on complete index, can go wrong, may regress existing behavior)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137794/new/

https://reviews.llvm.org/D137794



More information about the cfe-commits mailing list