[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Mon Nov 21 01:43:02 PST 2022

sammccall added a comment.

In D137205#3939720 <https://reviews.llvm.org/D137205#3939720>, @njames93 wrote:

> @sammccall I have a feeling you're gonna want to examine this checks feasibility in clangd.

Thanks! As it uses the CFG, by default we're going to have to turn it off (AFAIK building the CFG with broken code can still crash).
If you don't mind, please add it to the exclude list in `clang-tools-extra/clangd/TidyProvider.cpp` next to `-bugprone-use-after-move` (or I can do this after it lands).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137205/new/

https://reviews.llvm.org/D137205