[PATCH] D138391: clang/HIP: Add new header test for math IR gen

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 20 20:41:57 PST 2022


arsenm created this revision.
arsenm added reviewers: yaxunl, JonChesterfield, saiislam, b-sumner.
Herald added a subscriber: kosarev.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.

The current header testing is pretty thin. This is in
preparation for a series of patches to replace many
builtin implementations.

      

I did try to stress everything in this header, but skipped
a few things. Mostly I didn't understand why we have
various language version checks which skip defining some
things. It doesn't seem right to have any of these if guards
on __cplusplus,  __HIPCC_RTC__, and __OPENMP_AMDGCN__.


https://reviews.llvm.org/D138391

Files:
  clang/test/Headers/__clang_hip_math.hip
  clang/test/Headers/__clang_hip_math_ocml_rounded_ops.hip

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138391.476796.patch
Type: text/x-patch
Size: 178123 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221121/f747fd6e/attachment-0001.bin>


More information about the cfe-commits mailing list