[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

Fri Nov 18 14:14:49 PST 2022

rnk added subscribers: hans, compnerd, Bigcheese.
rnk added inline comments.

================
Comment at: llvm/unittests/Support/VirtualFileSystemTest.cpp:1878
+  // with native path seperator, regardless of the actual path seperator
+  // used in YAMLFilePath field.
+#ifndef _WIN32
----------------
dexonsmith wrote:
> bnbarham wrote:
> > `separator` -> `separator`
> > 
> > As per my comment above, this is only true because we're either using posix or windows_backslash. I'm not sure what we really want here, should we always convert to native? Any thoughts @dexonsmith?
> > 
> > FWIW the non-windows case is identical to the above block. It'd be interesting to test `/` and `\` on both filesystems.
> I think we might need a Windows person to help answer; @rnk, can you suggest someone to help answer @bnbarham's question?
I can try suggesting @hans, @compnerd, or @Bigcheese 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137473/new/

https://reviews.llvm.org/D137473