[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

Fri Nov 18 10:31:01 PST 2022

rjmccall added a comment.

In D138296#3937486 <https://reviews.llvm.org/D138296#3937486>, @arichardson wrote:

> In D138296#3937224 <https://reviews.llvm.org/D138296#3937224>, @eandrews wrote:
>
>> Functionally this looks ok to me. However I am not sure if CodeGenTypes is the 'right' place for this function to live, considering that other functions with similar functionality are in ASTContext - including overloads of getTargetAddressSpace( ). @erichkeane @aaron.ballman could you please take a look?
>
> My view is that the parts that interact with LLVM IR should really live in CodeGen/ and not Basic/ or AST/. I will see how difficult it would be to move the remaining target (LLVM IR) address space handling code to CodeGen/

Yeah, I don't think there's a good reason for some of the address-space stuff that currently lives in Basic to be there instead of in CodeGen.  Basic/AST need to understand what address spaces exist, their sizes, and what relationships they have with each other, and that's it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138296/new/

https://reviews.llvm.org/D138296