[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

Fri Nov 18 10:21:26 PST 2022

dblaikie added a comment.

In D138247#3936928 <https://reviews.llvm.org/D138247#3936928>, @probinson wrote:

> If this is specifically for C++17, I believe Sony doesn't officially support that yet although I am checking.

Cool, thanks!

> It looks like this is only part of the fix for #58819? The original report also had a `static int n` with an internal-linkage name.

Nah, it's the full fix - but the static member handling works correctly once you fix the type mangling itself, so the bug is in the type linkage/mangling, the static member was just the canary in the coal mine/a more visible effect of the bug. I could add test coverage for it, but by default I prefer to test more narrowly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138247/new/

https://reviews.llvm.org/D138247