[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

[Tom Stellard via Phabricator via cfe-commits]

tstellar added a comment.

In D138258#3936260 <https://reviews.llvm.org/D138258#3936260>, @kwk wrote:

> As much as I would like this to be fixed. I vote against this patch because in `lld/CMakeLists.txt` there's an almost (if not entirely) identical piece of code <https://github.com/llvm/llvm-project/blob/fcd5098a03dadcd11d4cc8b7155a4c07581999de/lld/CMakeLists.txt#L62> that screams to be outsourced into a `/cmake/Modules/FindLit.cmake` (to be created). I'll have a look at this and see if I can come up with a patch for this. Afterall `/cmake` is the central place to distribute shared CMake code between subprojects, right @phosek (didn't you create `/cmake` in the first place)?

My eventual goal is to move this out into a separate CMake file, but I was hoping to simplify the code first before doing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138258/new/

https://reviews.llvm.org/D138258