[PATCH] D138296: [clang] Avoid duplicating ProgramAddressSpace in TargetInfo. NFCI

Elizabeth Andrews via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 18 08:20:12 PST 2022


eandrews added subscribers: erichkeane, aaron.ballman.
eandrews added a comment.

Functionally this looks ok to me. However I am not sure if CodeGenTypes is the 'right' place for this function to live, considering that other functions with similar functionality are in ASTContext - including overloads of getTargetAddressSpace( ). @erichkeane @aaron.ballman could you please take a look?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138296/new/

https://reviews.llvm.org/D138296



More information about the cfe-commits mailing list