[PATCH] D137960: [Lexer] Speedup LexTokenInternal

serge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 18 01:12:02 PST 2022


serge-sans-paille added inline comments.


================
Comment at: clang/lib/Lex/Lexer.cpp:3520-3521
+LexStart:
+  assert(!Result.needsCleaning() && "Result doesn't need cleaning");
+  assert(!Result.hasPtrData() && "Result has been reset");
 
----------------
foad wrote:
> Messages are backwards. They should be like "Result needs cleaning!" and "Result has not been reset!".
Fixed as c8ecbaa2eba9de4338642bbfb6efd75b286878cb. Thanks for pointing that out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137960/new/

https://reviews.llvm.org/D137960



More information about the cfe-commits mailing list