[PATCH] D138227: [OPENMP]Initial support for severity clause

[Jennifer Yu via Phabricator via cfe-commits]

jyu2 added inline comments.


================
Comment at: clang/test/OpenMP/error_ast_print.cpp:16
 // CHECK: static int a;
-// CHECK-NEXT: #pragma omp error at(execution)
+// CHECK-NEXT: #pragma omp error at(execution) severity(fatal
 // CHECK-NEXT: a = argv[0][0];
----------------
ABataev wrote:
> Missed `)`
Thanks.  Changed.


================
Comment at: clang/test/OpenMP/error_message.cpp:79
+// expected-error at +1 {{ERROR}}
+#pragma omp error severity(fatal) severity(warning) // expected-error {{directive '#pragma omp error' cannot contain more than one 'severity' clause}}
+// expected-warning at +1 {{WARNING}}
----------------
ABataev wrote:
> What about a test for severity with the same severity kind?
I added one.  Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138227/new/

https://reviews.llvm.org/D138227