[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 17 09:04:36 PST 2022
MaskRay added inline comments.
================
Comment at: clang/lib/Lex/InitHeaderSearch.cpp:234
+ if (!ShouldAddDefaultIncludePaths(triple)) {
llvm_unreachable("Include management is handled in the driver.");
}
----------------
drop braces around simple single statements
================
Comment at: clang/lib/Lex/InitHeaderSearch.cpp:391
+ llvm::Triple::OSType os = triple.getOS();
+
+ // FIXME: temporary hack: hard-coded paths.
----------------
move the variable immediately before switch `os` and move the comment before the variable? Avoid unneeded blank lines
================
Comment at: clang/lib/Lex/InitHeaderSearch.cpp:104
+ /// ShouldAddDefaultIncludePaths - Returns true iff AddDefaultIncludePaths
+ /// should actually do anything. If this returns false, include management
+ /// should instead be handled in the driver.
----------------
MaskRay wrote:
> multiple spaces => one space
not done. `/// ` => `/// `
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138183/new/
https://reviews.llvm.org/D138183
More information about the cfe-commits
mailing list