[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 17 07:41:23 PST 2022


doru1004 marked 2 inline comments as done.
doru1004 added inline comments.


================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:1811
+      // clause.
+      if (getLangOpts().OpenMP >= 52 && ClauseName.str() == "to") {
+        Diag(Tok, diag::err_omp_declare_target_unexpected_to_clause);
----------------
ABataev wrote:
> ABataev wrote:
> > Do you really need `.str() `?
> Check for enter clause before 5.2?
Good catch, thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138159/new/

https://reviews.llvm.org/D138159



More information about the cfe-commits mailing list