[PATCH] D138194: [clang][Parser][NFC] Simplify ParseParenExprOrCondition

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 17 05:48:01 PST 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a minor improvement.



================
Comment at: clang/lib/Parse/ParseStmt.cpp:1275-1282
 bool Parser::ParseParenExprOrCondition(StmtResult *InitStmt,
                                        Sema::ConditionResult &Cond,
                                        SourceLocation Loc,
-                                       Sema::ConditionKind CK, bool MissingOK,
+                                       Sema::ConditionKind CK,
                                        SourceLocation *LParenLoc,
                                        SourceLocation *RParenLoc) {
+  assert(LParenLoc);
----------------
We can do better than an assert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138194/new/

https://reviews.llvm.org/D138194



More information about the cfe-commits mailing list