[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 16 23:19:05 PST 2022


owenpan added a comment.

@gedare thanks for changing `EXPECT_EQ` to `verifyFormat`, but IMO we should do that in another patch so that it would be easier (at least for me) to review the new tests and to make sure no existing tests have been changed by accident.



================
Comment at: clang/lib/Format/TokenAnnotator.cpp:5007
       return false;
     }
     const FormatToken *Previous = Right.MatchingParen->Previous;
----------------
Can we simply add the above and leave the original `return` statement on line 5009 unchanged?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137762/new/

https://reviews.llvm.org/D137762



More information about the cfe-commits mailing list