[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

In D137024#3931488 <https://reviews.llvm.org/D137024#3931488>, @mgorny wrote:

> Well, I'm certainly not opposed to making all the paths configurable. However, I'm not sure if having CMake file accessible one way or another wouldn't eventually be a necessity. For one thing, I would like to move more common code from standalone build codepaths of individual projects into a dedicated CMake file in LLVM (and while I don't want to speak of others, it seems that there are at least few other people who would like to see something similar done). I suppose this wouldn't be an outright blocker if `llvm/cmake/Modules` directory were present but I'm not 100% sure.

Isn't this two kinda separate concerns? If I build llvm but only install the executables (no libLLVMSupport.a, no cmake files etc), there's no LLVMConfig.cmake. But if I have the full llvm-project monorepo around, all the cmake helper scripts are available to be found in the monorepo - there's just no LLVMConfig.cmake (which is specific for one build of the llvm tools).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137024/new/

https://reviews.llvm.org/D137024