[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

[David Blaikie via Phabricator via cfe-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Couple of minor fixes for the test, but otherwise seems fine.



================
Comment at: clang/test/Driver/save-std-c++-module-file.cpp:1-4
+// RUN: rm -rf %t
+// RUN: mkdir %t
+// RUN: split-file %s %t
+//
----------------
Is this needed? Maybe we don't need to split the file, if it's just the one file anyway?


================
Comment at: clang/test/Driver/save-std-c++-module-file.cpp:6
+// RUN: %clang -std=c++20 %t/Hello.cppm -fsave-std-c++-module-file -### 2>&1 | \
+// RUN:   FileCheck %t/Hello.cppm -DPREFIX=%t
+//
----------------
Is the prefix needed? I'd expect we'd usually regex match away the actual directory with `{{.*}}` in tests like this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137058/new/

https://reviews.llvm.org/D137058