[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

Sam Elliott via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 16 10:11:47 PST 2022


lenary marked an inline comment as done.
lenary added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:47
 #include "llvm/Option/ArgList.h"
+#include "llvm/Support/ARMTargetParser.h"
 #include "llvm/Support/CodeGen.h"
----------------
tmatheson wrote:
> For consistency this could just come via ARM.h
Not any more! Those two headers don't need ARMTargetParserCommon.h so I moved their use into the implementation file, and now this is much better at avoiding transitive includes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137835/new/

https://reviews.llvm.org/D137835



More information about the cfe-commits mailing list