[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer
David Goldman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 16 09:43:06 PST 2022
dgoldman added a comment.
In D138047#3930211 <https://reviews.llvm.org/D138047#3930211>, @kadircet wrote:
> yeah unfortunately testing this is hard, but bug&fix are obvious so it's fine to land without a test.
>
> but i think we should rather fix the broken call site at clang-tools-extra/clangd/ParsedAST.cpp and move `BuildDir` to outer scope where it'll outlive IncludeFixer (~line 468).
Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138047/new/
https://reviews.llvm.org/D138047
More information about the cfe-commits
mailing list