[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

Wed Nov 16 09:16:33 PST 2022

rnk added subscribers: efriedma, hans.
rnk added a comment.

Sorry for the delay, dev meeting. I think we should try to add some reviewers for IR gen to help, I don't have a lot of time to be responsive:
https://github.com/llvm/llvm-project/blob/main/clang/CodeOwners.rst#clang-llvm-ir-generation
+ at efriedma @hans

================
Comment at: clang/test/CodeGenCXX/PR19955.cpp:17

-// CHECK-LABEL: @"??__Evarp@@YAXXZ"
-// CHECK-DAG: store ptr @"?var@@3HA", ptr @"?varp@@3PAHA"
----------------
This seems concerning to me, are we sure this is the right change? It's important that `varp` points to the imported `var`, and not a local copy, which is what https://llvm.org/PR19955 deals with.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137107/new/

https://reviews.llvm.org/D137107