[PATCH] D138117: [clang][docs] Correct floating point option explanations

Zahira Ammarguellat via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 16 09:16:02 PST 2022


zahiraam added a comment.

In D138117#3930423 <https://reviews.llvm.org/D138117#3930423>, @kawashima-fj wrote:

> I don't know it is inteded that `-fno-fast-math` does not imply `-ftrapping-math` and `-frounding-math`.
> `-ffast-math` and `-fno-fast-math` is not symmetric in RenderFloatingPointOptions <https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L3034>.

I would think that there should be symmetry between ffast-math and fno-fast-math.  Unless there is a good reason for it, in which case a comment should be added? @andrew.w.kaylor WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138117/new/

https://reviews.llvm.org/D138117



More information about the cfe-commits mailing list