[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

thanks for pinging @tom-anders , i've added some concerns about the behaviour in general. sorry if these are discussed somewhere else but i've missed.



================
Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:294
+}
+using namespace ns1::ns2;
+using namespace ns1::ns3;
----------------
sorry i am having trouble understanding why we are:
- only handling user defined literals from inline namespaces and not others?
- producing using directives and not using declarations
- inserting these at top level rather than where the usage is


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137817/new/

https://reviews.llvm.org/D137817