[clang] dcfb250 - [clang][deps] Remove checks that were just for exhaustiveness

Ben Langmuir via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 15 14:22:39 PST 2022


Author: Ben Langmuir
Date: 2022-11-15T14:22:23-08:00
New Revision: dcfb25078c2629450b393e696b97699990721a9f

URL: https://github.com/llvm/llvm-project/commit/dcfb25078c2629450b393e696b97699990721a9f
DIFF: https://github.com/llvm/llvm-project/commit/dcfb25078c2629450b393e696b97699990721a9f.diff

LOG: [clang][deps] Remove checks that were just for exhaustiveness

Instead of checking all the paths, just ensure the one we care about is
correct. On a particular platform one of the paths seems to have been
more canonical than we were expecting, which is fine.

Added: 
    

Modified: 
    clang/test/ClangScanDeps/modules-symlink-dir-from-module.c

Removed: 
    


################################################################################
diff  --git a/clang/test/ClangScanDeps/modules-symlink-dir-from-module.c b/clang/test/ClangScanDeps/modules-symlink-dir-from-module.c
index 5dde7708c2538..d1f7479adc6f9 100644
--- a/clang/test/ClangScanDeps/modules-symlink-dir-from-module.c
+++ b/clang/test/ClangScanDeps/modules-symlink-dir-from-module.c
@@ -19,38 +19,11 @@
 // CHECK: "modules": [
 // CHECK:   {
 // CHECK:     "command-line": [
+// CHECK-NOT: ]
 // CHECK:       "-fmodule-map-file=[[PREFIX]]/include/module/module.modulemap"
 // CHECK:     ]
 // CHECK:     "name": "Foo"
 // CHECK:   }
-// CHECK:   {
-// CHECK:     "command-line": [
-// FIXME: canonicalize this path
-// CHECK:       "-fmodule-map-file=[[PREFIX]]/include/symlink-to-module/module.modulemap"
-// CHECK:     ]
-// CHECK:     "name": "Foo_Private"
-// CHECK:   }
-// CHECK:   {
-// CHECK:     "command-line": [
-// CHECK:       "[[PREFIX]]/include/module/module.modulemap"
-// CHECK:     ]
-// CHECK:     "name": "Mod"
-// CHECK:   }
-// CHECK:   {
-// CHECK:     "command-line": [
-// FIXME: canonicalize this path
-// CHECK:       "-fmodule-map-file=[[PREFIX]]/include/symlink-to-module/module.modulemap"
-// CHECK:     ]
-// CHECK:     "name": "Other"
-// CHECK:   }
-// CHECK:   {
-// CHECK:     "command-line": [
-// FIXME: canonicalize this path
-// CHECK:       "-fmodule-map-file=[[PREFIX]]/include/symlink-to-module/module.modulemap"
-// CHECK:     ]
-// CHECK:     "name": "Test"
-// CHECK:   }
-// CHECK: ]
 
 //--- cdb.json.in
 [{


        


More information about the cfe-commits mailing list