[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

Chris Hamilton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 15 11:11:15 PST 2022


chrish_ericsson_atx added a comment.
Herald added a reviewer: njames93.

@mizvekov , I'm willing/trying to assist in addressing the buildbot failures that caused you to revert this change.  We are eager to see this fix land stably upstream as the crash it addresses is breaking a number of our internal tests.  Main thing I lack is any reasonable way to test code changes on aarch64, where it's breaking in buildbot.  Your last comment suggests to me that you believe this is a namespace issue; however, I don't see an obvious connection to namespace from the location where the crash occurs in the failing tests (at clang/lib/Serialization/ASTWriter.cpp:5455 in all the failed tests I reviewed).  Can you give a bit of context?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136886/new/

https://reviews.llvm.org/D136886



More information about the cfe-commits mailing list