[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir Ayupov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 15 09:22:12 PST 2022


Amir marked an inline comment as done.
Amir added inline comments.


================
Comment at: clang/cmake/modules/ClangBootstrap.cmake:10
+#     Optional arguments to pass to the build tool
+macro(clang_Bootstrap_Add name)
+  cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP"
----------------
phosek wrote:
> We usually use lowercase names.
Thanks! I was a bit confused by CMake's case use (e.g. `ExternalProject_Add`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133633/new/

https://reviews.llvm.org/D133633



More information about the cfe-commits mailing list