[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

Tue Nov 15 08:33:28 PST 2022

thesamesam added a comment.

In D136283#3911832 <https://reviews.llvm.org/D136283#3911832>, @sammccall wrote:

> I don't think we should add significant build-system complexity here in order to support the completion model on ppc32.
> Do people actually use clangd on ppc32 machines? (The linked bug calls this a clang build failure, but this code is not part of clang).
>
> If we need to support building on this toolchain, then we should probably just disable the decision forest model entirely and use the heuristic completion scorer instead.

I've had a think about this and I'm not aware of anyone using clangd on ppc32. So I agree this patch isn't worth the complexity. But it'd be nice to just switch to the heuristic scorer if it's somewhat easy rather than leave it broken (or bother having to wire up some "PPC is not supported" message). I've got no idea how to do that though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136283/new/

https://reviews.llvm.org/D136283