[PATCH] D137901: [Clang] `nothrow`-implying attributes should actually manifest `nothrow` attribute (PR58798)

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8794
+  case ParsedAttr::AT_Pure:
+    handleSimpleAttribute<PureAttr>(S, D, AL);
+    if (!D->hasAttr<NoThrowAttr>()) {
----------------
First, I'm not a fan of doing this in this list ast all, we shouldn't really have logic here, this is mostly just a jump table.

Second, I guess I'm not getting why IRGen cannot figure out from the AST that Pure/Const/NoAlias all imply nothrow?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137901/new/

https://reviews.llvm.org/D137901