[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace
v1nh1shungry via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 15 05:50:28 PST 2022
v1nh1shungry added inline comments.
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:212
// Produce replacements to add the qualifiers.
std::string Qualifier = printUsingNamespaceName(Ctx, *TargetDirective) + "::";
for (auto Loc : IdentsToQualify) {
----------------
We can replace `printUsingNamespaceName` with `printNamespaceScope` here so that we can get `a::foobar()` in the test.
However, it can sometimes cause redundancy such as in the 10th test.
And I don't know whether it is worth it. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138028/new/
https://reviews.llvm.org/D138028
More information about the cfe-commits
mailing list